Peter kulko/sync alpha to master branch #2730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: move enzyme to react testing library * feat: rewriting tests from Enzyme to RTL * refactor: update tests 2 * refactor: rewrite tests using react testing library * refactor: rewrite test using react testing library 2part * refactor: refactor after review part 1 * refactor: replace fireEvent with userEvent where it is possible * fix: fix console errors --------- Co-authored-by: monteri <lansevermore> Co-authored-by: PKulkoRaccoonGang <[email protected]> Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
…et (openedx#2705) * fix: fixed duplicate calls in FormRadioSet and FormCheckboxSet * refactor: added new tests * refactor: refactoring after review
# Conflicts: # package-lock.json # package.json # src/Button/deprecated/Button.test.jsx # src/CheckBox/CheckBox.test.jsx # src/CheckBoxGroup/CheckBoxGroup.test.jsx # src/Dropdown/deprecated/Dropdown.test.jsx # src/Dropdown/deprecated/__snapshots__/Dropdown.test.jsx.snap # src/Fieldset/Fieldset.test.jsx # src/Fieldset/index.jsx # src/Input/input.test.jsx # src/InputText/InputText.test.jsx # src/ListBox/ListBox.test.jsx # src/ListBoxOption/ListBoxOption.test.jsx # src/Modal/index.jsx # src/RadioButtonGroup/RadioButtonGroup.test.jsx # src/SearchField/__snapshots__/SearchField.test.jsx.snap # src/StatusAlert/StatusAlert.test.jsx # src/Table/Table.test.jsx # src/Table/index.jsx # src/Tabs/deprecated/Tabs.test.jsx # src/ValidationFormGroup/ValidationFormGroup.test.jsx # src/ValidationFormGroup/__snapshots__/ValidationFormGroup.test.jsx.snap # src/ValidationFormGroup/index.jsx
openedx-webhooks
added
the
open-source-contribution
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for the pull request, @PKulkoRaccoonGang! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
|
@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist